Use libclang include path in tests #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the supported and upcoming releases.
Remove the EOL releases.
This is the package for C headers.
Split out the _Bool/bool tests and run them in C only. They're problematic in C++ because they depend on stdbool.h, and specifically on GCC version of it which defines _Bool bool for C++. This is problematic on Alpine Linux which uses musl, as well as on macOS. Annoyingly the anonymous struct names also change.
This reverts commit a114bf7 ("test: query system include args from clang"). This is no longer an issue with any of the current Docker images, and with the C/C++ includes sorted out. We should try to trust libclang to have the header search path right.
jnikula
changed the title
BrunoMSantos
approved these changes
Sep 11, 2024
Don't worry about it, and thanks for going through them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort out C header stuff, update Docker images, and stop asking clang for the header search path during testing. This is no longer an issue with the current images.