Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile updates #234

Merged
merged 12 commits into from
Jan 27, 2024
Merged

Makefile updates #234

merged 12 commits into from
Jan 27, 2024

Commits on Jan 27, 2024

  1. test: rename test-examples to check-examples 

    Name all static analysis make targets check-*.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    2770bb2 View commit details
    Browse the repository at this point in the history

  2. check: rename 'check' to 'check-style' and repurpose 'check' 

    Rename 'make check' to 'make check-style', and repurpose 'make check' to
run all static analysis.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    6715f25 View commit details
    Browse the repository at this point in the history

  3. build: remove html -> rst build rule 

    The html -> rst rule was added in commit b89cc7d ("doc: don't
include README in documentation") with the idea it would be used for
checking README.rst. It was superceded by the check added in commit
6d9f0a9 ("build: add check-rst target to lint rst"). Remove the
rule.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    c600b48 View commit details
    Browse the repository at this point in the history

  4. build: remove the quiet build hacks 

    There's ancient support for quiet and verbose builds with 'make V=0' and
'make V=1', but they're only used for the clean and distclean
targets. Rather than tediously fix all the other targets to use this
machinery, just rip it off. They're not all that verbose anyway.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    6560fce View commit details
    Browse the repository at this point in the history

  5. build: remove Makefile.rules 

    Makefile.rules has diminished so small there's not much point in keeping
it around. Just merge to top level Makefile.local.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    3b1b656 View commit details
    Browse the repository at this point in the history

  6. build: include local Makefiles dynamically 

    Instead of listing all the subdirs manually, find all the Makefile.local
files instead.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    07092ed View commit details
    Browse the repository at this point in the history

  7. build: simplify subdir Makefiles 

    There are Makefiles in subdirectories to allow running make in the
subdirectories. It's kind of handy, so keep it, but simplify the
Makefiles. Rename 'all' target to 'default' to better describe its
purpose.

Turns out src/hawkmoth/Makefile was not updated after the src/
addition. Fix it while at it.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    87ef915 View commit details
    Browse the repository at this point in the history

  8. build: remove some stale comments 

    Most of the releasing stuff hasn't been merged anywhere, and it's a bit
haphazard. It could be improved. But the fixme comments in the Makefile
aren't really helpful either. Remove them.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    214f4c7 View commit details
    Browse the repository at this point in the history

  9. build: fix cleaning of pycache 

    The old rule dates back to Python 2.7.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    fd45724 View commit details
    Browse the repository at this point in the history

  10. build: unify docdir to doc_dir 

    Make it similar to test_dir. Remove the unnecessary dir variable while
at it.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    b4be2a0 View commit details
    Browse the repository at this point in the history

  11. build: use src_dir instead of dir 

    Make it similar to test_dir and doc_dir. Remove the unnecessary top
level dir variable while at it.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    b840bb4 View commit details
    Browse the repository at this point in the history

  12. build: add missing .PHONY deps 

    Most of our targets are phony. Add the missing .PHONY annotations.
    @jnikula
    jnikula committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    e6bdda4 View commit details
    Browse the repository at this point in the history