Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: require send as well as sync #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat!: require send as well as sync #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jmespath/src/functions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::{Context, ErrorReason, JmespathError, Rcvar, RuntimeError};
use serde_json::Number;

/// Represents a JMESPath function.
pub trait Function: Sync {
pub trait Function: Sync + Send {
/// Evaluates the function against an in-memory variable.
fn evaluate(&self, args: &[Rcvar], ctx: &mut Context<'_>) -> SearchResult;
}
Expand Down Expand Up @@ -102,14 +102,14 @@ pub struct CustomFunction {
/// Signature used to validate the function.
signature: Signature,
/// Function to invoke after validating the signature.
f: Box<dyn Fn(&[Rcvar], &mut Context<'_>) -> SearchResult + Sync>,
f: Box<dyn Fn(&[Rcvar], &mut Context<'_>) -> SearchResult + Sync + Send>,
}

impl CustomFunction {
/// Creates a new custom function.
pub fn new(
fn_signature: Signature,
f: Box<dyn Fn(&[Rcvar], &mut Context<'_>) -> SearchResult + Sync>,
f: Box<dyn Fn(&[Rcvar], &mut Context<'_>) -> SearchResult + Sync + Send>,
) -> CustomFunction {
CustomFunction {
signature: fn_signature,
Expand All @@ -132,7 +132,7 @@ impl Function for CustomFunction {
/// validation, it is recommended to use CustomFunction.
impl<F> Function for F
where
F: Sync + Fn(&[Rcvar], &mut Context<'_>) -> SearchResult,
F: Send + Sync + Fn(&[Rcvar], &mut Context<'_>) -> SearchResult,
{
fn evaluate(&self, args: &[Rcvar], ctx: &mut Context<'_>) -> SearchResult {
(self)(args, ctx)
Expand Down