Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static url variables to init #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gadigg
Copy link

@Gadigg Gadigg commented Nov 8, 2019

This is done so that the user can change the url where the static files are served from. In case the swagger ui is served from behind a gateway.

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #171 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   97.71%   97.73%   +0.01%     
==========================================
  Files           8        8              
  Lines         350      353       +3     
==========================================
+ Hits          342      345       +3     
  Misses          8        8
Impacted Files Coverage Δ
flask_apispec/extension.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1842221...77601d0. Read the comment docs.

@ziplokk1
Copy link

Any chance this will get merged in?

@rachekalmir
Copy link

Also interested in this MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants