Resolved two issues: added support for MKV files and clarified "error" printed output #461
Conversation
there is now a new type of result, duplicate files these are files that already exist in the destination folder and are not imported if not importing duplicates I have thoroughly verified that my changes do not cause any other part of the code to break or act in an unexpected manner. I have also removed some code that could never get used: elodie/localstorage.py: checksum() could never return None, code was not accessible due to earlier return because of this: elodie/filesystem.py: process_checksum() did not need to check if checksum was None after calculating it this is what allowed my new code to use None as a flag meaning that the file being imported and skipped is a duplicate file
|
|
|
The fail on ci/circleci is due to the printed output being changed in |
|
I am working on updating the tests for my code, I'll need to create another PR when it's done. I have noticed that my code does fail 4 tests, even after updating the tests. so I will figure that out now |
|
oh I don't need to make a new PR apparently. cool. Well as you can see I've updated the tests to the new formatting and fixed the minor issue that had caused 4 of them to fail |
|
On this note: We should really add some test cases to test the functionality of trying to import a file that has already been imported, to see if the duplicate count goes up |
|
the test that has now failed (for whatever reason) has nothing to do with any code I have changed. Odd |
|
I changed nothing and now the test passes. It seems that the failed test was a HTTPS call to that geolocation server. Annoying |
|
Another note. Is there any documentation that needs to be updated with this "UI" change? |
video file extensions
as they are supported by exiftool
resolved: #457
resolved: #460