Fix bug using bool to test prefer_english_names #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2020
jmathai
requested changes
Apr 22, 2020
| @@ -135,7 +136,7 @@ def get_prefer_english_names(): | |||
| if('prefer_english_names' not in config['MapQuest']): | |||
| return False | |||
|
|
|||
| __PREFER_ENGLISH_NAMES__ = bool(config['MapQuest']['prefer_english_names']) | |||
| __PREFER_ENGLISH_NAMES__ = bool(strtobool(config['MapQuest']['prefer_english_names'])) | |||
There was a problem hiding this comment.
Thanks - I think we can eliminate the bool() call here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in PR 290 and closes issue #369 (Prefer English names logic is broken).
boolcannot be used to test for a True or False string in python.This uses the standard routine
distutils.util.strtoboolto check the string provided in config.ini. This will correctly interpret: y, yes, t, true, on, 1, false, n, no, f, false, off, 0 and is case-insensitive.I'm not sure how this slipped through the tests before...