Feature/delete duplicates #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ish as accepted header to MapQuest requests and results in the response location names being mostly in English not their native country language.
…ommand line option
…olders command line option" This reverts commit 03d4a9c.
This reverts commit b94372b.
…han %location or %date provide jmathai#279 (jmathai#283)
* 'master' of github.com:jmathai/elodie: Add support for mts video files with H264:DateTimeOriginal create date field support (jmathai#295) Add support for customizing file name via config file. jmathai#107 jmathai#110 jmathai#111 (jmathai#225) Implements prefer english names setting for MapQuest API in config.ini (jmathai#290) Add support for a %custom placeholder for more complex folder names than %location or %date provide jmathai#279 (jmathai#283) # Conflicts: # Readme.md # elodie/filesystem.py
This was referenced Feb 4, 2019
jmathai
requested changes
Feb 13, 2019
| _file, | ||
| checksum_file | ||
| )) | ||
| if constants.delete_duplicates: |
There was a problem hiding this comment.
Need to import constants at the top of the file.
https://travis-ci.org/jmathai/elodie/jobs/488449125
| _file, | ||
| checksum_file | ||
| )) | ||
| if constants.delete_duplicates: |
There was a problem hiding this comment.
I would rather include this check in delete_file() so it can be called in a safer manner from other spots if needed.
| @@ -80,6 +80,20 @@ def delete_directory_if_empty(self, directory_path): | |||
|
|
|||
| return False | |||
|
|
|||
| def delete_file(self, file_path): | |||
There was a problem hiding this comment.
We should add tests for this including for when delete_duplicates is True and False.
jmathai
force-pushed
the
master
branch
4 times, most recently
from
3276ccf
to
12c17c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements deleting duplicates on import with --delete-duplicates flag.