Fix problem with faulty triggers in waiting_triggers #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can sometimes happen, that the job processing stops completely due to an erroneous trigger state.
When acquiring next triggers, we check for them in the "waiting_triggers" entry. We take the topmost entry and try to retrieve the actual trigger. If for some reason this trigger does not exist, we run into a NullPointerException in applyMisfire, and even worse, the trigger does not get removed from "waiting_triggers", therefore the behaviour repeats itself.
This PR introduces a check if the retrieved trigger is null, and if yes, it removes it from "waiting_triggers", from "triggers" and also deletes its trigger data map.
FYI: This behaviour is not related to #35 . There are no special characters in the keys when this happens.