Add a configuration file #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlevesy
force-pushed
the
jl/kudo-50/configuration-file
branch
from
8e8aafa
to
140a419
Compare
jlevesy
force-pushed
the
jl/kudo-50/configuration-file
branch
4 times, most recently
from
c70e5d1
to
3460a24
Compare
this is done to make this type fully comparable
jlevesy
force-pushed
the
jl/kudo-50/configuration-file
branch
from
3460a24
to
4528eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR do?
This PR adds a config file to Kudo and removes all CLI arguments. This allow for a much more extensive configuration and is way more future proof from what we have.
It also carries a fix on the type
ValueWithKindwhich wasn't properly operating when reencoding a value that has been already encoded.Fixes: #50
How to Test This PR?
# mess around with the new values introduces in the `values.yaml` make run_devGood PR Checklist
Additional Notes
This PR is far for complete:
e2e is broken