Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error when offset doesn't match expected #34

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

jkeifer
Copy link
Owner

@jkeifer jkeifer commented Aug 13, 2023

Error now contains expected_offset and provided_offset instead of the ambiguous offset.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

Merging #34 (e716b33) into main (ed96cf3) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files           8        8           
  Lines         335      335           
=======================================
  Hits          315      315           
  Misses         20       20           
Files Changed Coverage Δ
src/drf_chunked_upload/views.py 94.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jkeifer jkeifer merged commit bf29090 into main Aug 13, 2023
7 checks passed
@jkeifer jkeifer deleted the better-offset-error branch August 13, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants