Gh/ts/patch 025 service authentication authentication events

service/authentication/AuthenticationEvents.spec.ts

@@ -6,14 +6,18 @@ describe( "/service/authentication/AuthenticationEvents members", () => {
     const {
         IDENTITY_UPDATED,
         AuthenticationEvents,
+        default: AuthenticationEventsDefault,
         ...others
-    } = exported as any; // TODO: remove cast after typescript conversion
+    } = exported;
 
     it( "known members", () => {
         expect( IDENTITY_UPDATED ).toBe( 'authentication.identity_updated' );
-        if ( AuthenticationEvents ) {
-            expect( AuthenticationEvents.IDENTITY_UPDATED ).toBe( 'authentication.identity_updated' );
-        }
+
+        expect( AuthenticationEvents ).toBeDefined();
+        expect( AuthenticationEvents.IDENTITY_UPDATED ).toBe( 'authentication.identity_updated' );
+
+        expect( AuthenticationEventsDefault ).toBeDefined();
+        expect( AuthenticationEventsDefault.IDENTITY_UPDATED ).toBe( 'authentication.identity_updated' );
     } );
 
     it( "unknown members", () => {

service/authentication/AuthenticationEvents.js → service/authentication/AuthenticationEvents.ts

@@ -1,4 +1,4 @@
-const AuthenticationEvents = {
+export enum AuthenticationEvents {
     /**
      * Event callback arguments:
      * function(authenticationEnabled, userIdentity)
@@ -7,7 +7,12 @@ const AuthenticationEvents = {
      * userIdentity - if user has been logged in then it contains user name. If
      *                contains 'null' or 'undefined' then user is not logged in.
      */
-    IDENTITY_UPDATED: 'authentication.identity_updated'
+    IDENTITY_UPDATED = 'authentication.identity_updated'
 };
 
-module.exports = AuthenticationEvents;
+export const IDENTITY_UPDATED = AuthenticationEvents.IDENTITY_UPDATED;
+
+// TODO: this was a pre-ES6 module using module.exports = AuthenticationEvents which doesn't translate well
+// it is used in a number of places and should be updated to use the named export
+
+export default AuthenticationEvents;

types/auto/service/authentication/AuthenticationEvents.d.ts

@@ -1 +1,13 @@
-export const IDENTITY_UPDATED: string;
+export declare enum AuthenticationEvents {
+    /**
+     * Event callback arguments:
+     * function(authenticationEnabled, userIdentity)
+     * authenticationEnabled - indicates whether authentication has been enabled
+     *                         in this session
+     * userIdentity - if user has been logged in then it contains user name. If
+     *                contains 'null' or 'undefined' then user is not logged in.
+     */
+    IDENTITY_UPDATED = "authentication.identity_updated"
+}
+export declare const IDENTITY_UPDATED = AuthenticationEvents.IDENTITY_UPDATED;
+export default AuthenticationEvents;