Covert BrowserDetection to TS #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove BrowserCapabilities class since lib-jitsi-meet no longer uses it.
saghul
requested changes
Aug 14, 2024
| * @returns {boolean|undefined} - Returns true if the current version is | ||
| * greater than the passed version and false otherwise. Returns undefined if | ||
| * the current browser version is unknown. | ||
| */ | ||
| isVersionGreaterThan(version) { | ||
| isVersionGreaterThan(version: number): boolean | undefined { |
There was a problem hiding this comment.
Let's make this return a boolean always. If the version is not available, return false.
| * @returns {boolean|undefined} - Returns true if the current version is | ||
| * lower than the passed version and false otherwise. Returns undefined if | ||
| * the current browser version is unknown. | ||
| */ | ||
| isVersionLessThan(version) { | ||
| isVersionLessThan(version: number): boolean | undefined { |
| * @returns {boolean|undefined} - Returns true if the current version is | ||
| * equal to the passed version and false otherwise. Returns undefined if | ||
| * the current browser version is unknown. | ||
| * A loose-equality operator is used here so that it matches the sub-versions as well. | ||
| */ | ||
| isVersionEqualTo(version) { | ||
| isVersionEqualTo(version: number): boolean | undefined { |
| * @returns {boolean|undefined} - Returns true if the current version is | ||
| * greater than the passed version and false otherwise. Returns undefined if | ||
| * the current engine version is unknown. | ||
| */ | ||
| isEngineVersionGreaterThan(version) { | ||
| isEngineVersionGreaterThan(version: number): boolean | undefined { |
| * @returns {boolean|undefined} - Returns true if the current version is | ||
| * lower than the passed version and false otherwise. Returns undefined if | ||
| * the current engine version is unknown. | ||
| */ | ||
| isEngineVersionLessThan(version) { | ||
| isEngineVersionLessThan(version: number): boolean | undefined { |
| * @returns {boolean|undefined} - Returns true if the current version is | ||
| * equal to the passed version and false otherwise. Returns undefined if | ||
| * the current engine version is unknown. | ||
| * A loose-equality operator is used here so that it matches the sub-versions as well. | ||
| */ | ||
| isEngineVersionEqualTo(version) { | ||
| isEngineVersionEqualTo(version: number): boolean | undefined { |
| @@ -0,0 +1,36 @@ | |||
|
|
|||
| // TODO: Maybe fix the values to 'Chrome', 'Internet Explorer', etc. Currently | |||
| * Maps the names of the browsers from ua-parser to the internal names defined in | ||
| * ./browsers.js | ||
| */ | ||
| export const PARSER_TO_JITSI_NAME: { [key: string]: Browser } = { |
There was a problem hiding this comment.
How do we parse Chromium engine browsers like Edge or Brave?
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@jitsi/js-utils", | |||
| "version": "2.2.1", | |||
| "version": "2.2.2", | |||
There was a problem hiding this comment.
The auto-publisher ran because you used your master branch. Can you back out the version change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove BrowserCapabilities class since lib-jitsi-meet no longer uses it.