Add some more Duration and Instant helper utils #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrozev
reviewed
Sep 5, 2024
| @@ -40,5 +44,59 @@ val Number.mins: Duration | |||
| val Number.days: Duration | |||
| get() = Duration.ofDays(this.toLong()) | |||
|
|
|||
| operator fun Duration.times(x: Int): Duration = Duration.ofNanos(toNanos() * x) | |||
| operator fun Duration.times(x: Number): Duration = this.multipliedBy(x.toLong()) | |||
There was a problem hiding this comment.
This accepts a Number but will not work as expected with e.g. 1.5. I see that kotlin.time.Duration already has a times(scale: Double). Can we use kotlin Duration everywhere?
bgrozev
previously approved these changes
Sep 5, 2024
The results are unexpected and undesirable for Float and Double.
bgrozev
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these are moved from jitsi-media-transform's utils directory.