Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) update electron to 32.0.2 #980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

csett86
Copy link
Member

@csett86 csett86 commented Sep 8, 2024

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure what the test failure is about...

@csett86
Copy link
Member Author

csett86 commented Sep 9, 2024

@saghul I found the issue of the failed mac build: The signing certificate (Developer ID Certificate) expired (its a bit hidden):

allIdentities=  1) 73C17FEC46D7EA4F1DA953AD30771A3A32A0C85F "Developer ID Application: 8x8, Inc. (***)" (CSSMERR_TP_CERT_EXPIRED)

See https://github.com/jitsi/jitsi-meet-electron/actions/runs/10762727231/job/29862036735#step:5:886

Could I kindly as you to get a renewed Developer ID Certificate from 8x8 Apple Account Holder and add it to the secrets (same as 2021: #581 (comment))

@saghul
Copy link
Member

saghul commented Sep 9, 2024

Will do, thanks for the heads up!

@saghul
Copy link
Member

saghul commented Sep 23, 2024

I have requested a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants