Skip to content

Commit

Permalink
use compareTo when comparing Jids (#339)
Browse files Browse the repository at this point in the history
the previous code was causing an issue where we'd compare the same JID
content (but different references) and Jicofo thought they weren't the
same.
  • Loading branch information
bbaldino authored Jan 24, 2019
1 parent f3bbfbb commit 1788f06
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -490,10 +490,10 @@ private void handleJibriStatusUpdate(
jibriStatus = newStatus;
logger.info("Got Jibri status update: Jibri " + jibriJid + " has status " + newStatus +
" and failure reason " + failureReason);
if (jibriJid != currentJibriJid)
if (jibriJid.compareTo(currentJibriJid) != 0)
{
logger.info("This status update is from " + jibriJid +
"but the current Jibri is " + currentJibriJid + ", ignoring");
" but the current Jibri is " + currentJibriJid + ", ignoring");
return;
}
// First: if we're no longer pending (regardless of the Jibri's new state), make sure we stop
Expand Down

0 comments on commit 1788f06

Please sign in to comment.