Use ggsvg for rendering #36
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(New flag masks still not working)
Plots flags, but justification is off a bit and produces Error in if (rasterRatio > vpRatio) { :
missing value where TRUE/FALSE needed
}
|
Seeing how https://github.com/coolbutuseless/ggsvg/blob/main/R/ggsvg.R does it is v helpful, even though that package is much more complex with its CSS overrides! |
added 2 commits
June 3, 2024 20:43
|
This is looking pretty good now! 🥳 library(ggplot2)
devtools::load_all()
gdp <- data.frame(
name = c("us", "cn", "jp", "de", "in", "gb", "fr", "it", "ca"),
gdp = c(26854, 19374, 4410, 4309, 3740, 3160, 2924, 2170, 2090),
x = c(1, 2, 3, 1, 2, 3, 1, 2, 3),
y = c(3, 3, 3, 2, 2, 2, 1, 1, 1))
p1 <- ggplot(gdp) +
aes(x, y) +
geom_flag(aes(country = name, size = gdp),
key_glyph = draw_key_flag("jp")) +
geom_point(aes(size = gdp), colour = "#00ff0099") +
geom_text(
aes(label = toupper(name)),
nudge_y = -0.3,
size = 9,
family = "Inter",
fontface = "bold") +
geom_text(
aes(label = scales::label_dollar()(gdp)),
family = "Inter",
nudge_y = -0.45,
size = 12) +
scale_size(
range = c(1, 60),
guide = guide_none()
) +
scale_x_continuous(expand = expansion(.22)) +
scale_y_continuous(expand = expansion(.22)) +
theme_void(base_size = 28, base_family = "Inter") +
theme(
plot.title = element_text(face = "bold"),
plot.subtitle = element_text(colour = "#333333")
) +
labs(
title = "Top 10 economies by GDP",
subtitle = "In $US billions in 2023",
caption = "Source: International Monetary Fund"
) +
coord_cartesian(clip = "off")
ggsave("test.png", p1, bg = "white", width = 10, height = 13)
|
jimjam-slam
commented
Jun 4, 2024
| ) | ||
| grid::setChildren(x, do.call(grid::gList, flag_pics)) | ||
| flag_size <- size * grid::unit(1, "mm") | ||
| flag_grob <- ggsvg::svg_to_rasterGrob( |
There was a problem hiding this comment.
If I convert the svg_text to raw using charToRaw(), I can skip ggsvg and use rsvg::rsvg_nativeraster() instead (which takes the same arguments). That's probably for the best, as I don't think Mike intends for ggsvg to be super maintained, and rsvg is well maintained.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids clipping problems with
grImport2(see #17). Still a WIP: flags are successfully drawn, but problems to fix are:Error in if (rasterRatio > vpRatio) { : missing value where TRUE/FALSE needed }