Skip to content

Commit

Permalink
HID: wacom: Hardcode (non-inverted) AES pens as BTN_TOOL_PEN
Browse files Browse the repository at this point in the history
Unlike EMR tools which encode type information in their tool ID, tools
for AES sensors are all "generic pens". It is inappropriate to make use
of the wacom_intuos_get_tool_type function when dealing with these kinds
of devices. Instead, we should only ever report BTN_TOOL_PEN or
BTN_TOOL_RUBBER, as depending on the state of the Eraser and Invert
bits.

Fixes: 9c2913b962da ("HID: wacom: more appropriate tool type categorization")
Signed-off-by: Jason Gerecke <[email protected]>
  • Loading branch information
jigpu committed Oct 8, 2024
1 parent 5010aed commit 8046f5d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions 4.18/wacom_wac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2592,6 +2592,8 @@ static void wacom_wac_pen_report(struct hid_device *hdev,
/* Going into range select tool */
if (wacom_wac->hid_data.invert_state)
wacom_wac->tool[0] = BTN_TOOL_RUBBER;
else if (wacom_wac->features.quirks & WACOM_QUIRK_AESPEN)
wacom_wac->tool[0] = BTN_TOOL_PEN;
else if (wacom_wac->id[0])
wacom_wac->tool[0] = wacom_intuos_get_tool_type(wacom_wac->id[0]);
else
Expand Down

0 comments on commit 8046f5d

Please sign in to comment.