Skip to content

Commit

Permalink
HACK: Don't actually remove pen from prox when hung in-prox
Browse files Browse the repository at this point in the history
It almost certianly should not be the case that sending the pen out of
prox makes jumps worse. However, for the sake of scientific inquiry,
lets give it a shot.

NOTE: Being hung in-prox means that we haven't received an event in a
while. By the very nature of this, it means that the pointer is going
to make a large jump from its last-known location to whatever its new
position is once we start getting events again. Wether we remove the
pen from prox or not, that jump *will* happen.
  • Loading branch information
jigpu committed Nov 9, 2023
1 parent d212d14 commit 7e1c20e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion 4.5/wacom_wac.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ static int wacom_numbered_button_to_key(int n);
static void wacom_update_led(struct wacom *wacom, int button_count, int mask,
int group);

#if 0
static void wacom_force_proxout(struct wacom_wac *wacom_wac)
{
struct input_dev *input = wacom_wac->pen_input;
Expand All @@ -64,6 +65,7 @@ static void wacom_force_proxout(struct wacom_wac *wacom_wac)

input_sync(input);
}
#endif

#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,14,0)
void wacom_idleprox_timeout(struct timer_list *list)
Expand All @@ -81,7 +83,7 @@ void wacom_idleprox_timeout(unsigned long data)
}

hid_warn(wacom->hdev, "%s: tool appears to be hung in-prox. forcing it out.\n", __func__);
wacom_force_proxout(wacom_wac);
//wacom_force_proxout(wacom_wac);
}

/*
Expand Down

0 comments on commit 7e1c20e

Please sign in to comment.