Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate table class definition and instantiation in MultiTableMixin #876 #885

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Separate table class definition and instantiation in MultiTableMixin #876 #885

wants to merge 14 commits into from
+48 −11

Commits on Dec 3, 2022

  1. Modify MultiTableMixin api to be a bit more like SingleTableMixin wit… 

    …h a separation between table class definition and instantiation.
    @gb119
    gb119 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    9a6fef7 View commit details
    Browse the repository at this point in the history

  2. Tweak sourfce formatting to get actions to run

    @gb119
    gb119 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    42fe084 View commit details
    Browse the repository at this point in the history

  3. Remove MultiTableMixin models attribute - not allowing tests to work.… 

    … Add new test for MultiTableMixin.get_tables_classes
    @gb119
    gb119 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    43323e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Reapply MultiTableMixin.get_tables_calsses 

    Re do the change to allow MultiTableClasses.get_tablers_classes, but this time with f-string formatting.
    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    6459dd1 View commit details
    Browse the repository at this point in the history

  2. MultTable.get_tables_classes() tweaking 

    Make the test for get_tables_classes() use a list of tables. Test will probably fail
    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    e071075 View commit details
    Browse the repository at this point in the history

  3. Update test with correct exception message

    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    6aa6dbd View commit details
    Browse the repository at this point in the history

  4. Missed f string change

    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    6824551 View commit details
    Browse the repository at this point in the history

  5. Add tables data to get_tables_classes test

    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    1ae9a63 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:gb119/django-tables2 

    Update formatting, fix test regressions
    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    bd51a8e View commit details
    Browse the repository at this point in the history

  7. Run tests through black

    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    7907edb View commit details
    Browse the repository at this point in the history

  8. Remove long line in views.py

    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    8873e7a View commit details
    Browse the repository at this point in the history

  9. Resync to remote/HEAD and reapply the get_tables_classes() change wit… 

    …h requested cahnges.
    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    60fff48 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of github.com:gb119/django-tables2

    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    72292f2 View commit details
    Browse the repository at this point in the history

  11. Fix misnamed test

    @gb119
    gb119 committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    09c7c72 View commit details
    Browse the repository at this point in the history