Fix converter custom parameter builder (AudioSegment.from_file) #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shifts the standard output (-) parameter to be the last one in the converter parameters so custom input parameters can take effect for conversion using ffmpeg.
I have faced issues when using the parameter
-map
to select audio streams for conversion as it only take effect if before stdout parameter.Wrong:
ffmpeg -y -i input -f wav - -map 0:1 > test-wrong.wav
Right:
ffmpeg -y -i input -f wav -map 0:1 - > test-right.wav
In the examples above, only
test-right.wav
is successfully converted given the selected stream index (i.e. 1).This follows the established usage instructions where the output destination should be the last parameter to specify (i.e. output_url):