More options added #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthapar
commented
Jun 27, 2018
vthapar
commented
- Distribution repo support
- Custom feature option for build
- down script to stop/rm a node
1. Distribution repo support 2. Custom feature option for build 3. down script to stop/rm a node
jhershberg
reviewed
Jun 28, 2018
| exit 2 | ||
| fi | ||
| targetpath=${path}/karaf/target | ||
| feature="odl-netvirt-openstack" | ||
| feature=${2:-"odl-netvirt-openstack"} |
There was a problem hiding this comment.
To me it makes sense that if the user passes in a list of features that should be it, no? It would be more flexible. Like, maybe someone would want to use this to test some feature that has nothing to do with netvirt or genius, etc. On the other hand, if someone is specifying the list of features, it's not such a big deal to tack on odl-netvirt-openstack.
| @@ -0,0 +1,9 @@ | |||
| set +x | |||
There was a problem hiding this comment.
I think this script overlaps too much with wipe. I say delete wipe (wipe wipe ;-).
Also, I think both of these changes should be documented in the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.