Refined a try catch.

jexuswebserver · Apr 6, 2023 · f135e9b · f135e9b
1 parent d542d44
commit f135e9b
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/JexusManager.Features.Certificates/SelfCertificateDialog.cs b/JexusManager.Features.Certificates/SelfCertificateDialog.cs
@@ -168,7 +168,6 @@ public SelfCertificateDialog(IServiceProvider serviceProvider, CertificatesFeatu
                             start.WindowStyle = ProcessWindowStyle.Hidden;
                             process.Start();
                             process.WaitForExit();
-                            File.Delete(p12File);
                             if (process.ExitCode == 0)
                             {
                                 DialogResult = DialogResult.OK;
@@ -189,8 +188,18 @@ public SelfCertificateDialog(IServiceProvider serviceProvider, CertificatesFeatu
                         }
                         catch (Exception ex)
                         {
+                            ShowError(ex, $"unexpected exception", false);
                             RollbarLocator.RollbarInstance.Error(ex);
                         }
+                        finally
+                        {
+                            if (File.Exists(p12File))
+                            {
+                                File.Delete(p12File);
+                            }
+                        }
+
+                        // TODO: flatten the two try catch.
                     }
                     catch (Exception ex)
                     {