[Ephemeral Storage] Add request for minimum size of ephemeral storage… #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Medium+ instances
ipince
approved these changes
Aug 30, 2023
|
Don't wanna land this unless @gcurtis can confirm it works. |
|
Is this for search service? |
|
Mike confirmed it compiles |
savil
added a commit
that referenced
this pull request
Aug 31, 2023
#57) … storage… (#56)" This reverts commit 1c7247e. ## Summary This PR reverts the change, since AFAIK Greg couldn't successfully deploy with this change. He found another workaround for his service (using a compact DB). ## How was it tested? compiles. Did `git revert <commit hash>` ## Is this change backwards-compatible? yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for Medium+ instances
Summary
Medium-Plus instance projects may likely require more disk space. So, make a minimum request of 8GB.
Ping internally for additional motivations.
How was it tested?
Did not test.
Tried compiling (but fails on x86-darwin for nix reasons; looking into it)
Is this change backwards-compatible?
yes