[docker] Experimental, use docker cli directly #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcurtis
approved these changes
Aug 1, 2023
pkg/cmdutil/exec.go
Outdated
| ) | ||
|
|
||
| func CommandTTY(name string, arg ...string) *exec.Cmd { | ||
| cmd := exec.Command(name, arg...) |
pkg/cmdutil/exec.go
Outdated
| "os/exec" | ||
| ) | ||
|
|
||
| func CommandTTY(name string, arg ...string) *exec.Cmd { |
There was a problem hiding this comment.
You are right, it only needs to bind stdout/err.
I copy pasted this from devbox repo where stdin needs to be set for the CLI to output in a certain way. In this case it doesn't need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current golang docker client is broken under golang 1.20.6. There's a patched release but we can't update to it because helm it tied to current release. This is a temporary fix.
How was it tested?
LAUNCHPAD_USE_DOCKER_CLI=1 launchpad up devtools/buildkite/lagobot-appIs this change backwards-compatible?
Yes