Skip to content

Commit

Permalink
changed trigger to release to dockerhub to run on published releases (#…
Browse files Browse the repository at this point in the history
…2311)

## Summary
Previously we ran docker image build and publish to dockerhub when a new
tag was created, but this introduced a bug when a tag was created as a
draft it would trigger this run but the assets from the tag weren't
publicly available yet.
This change makes sure that the tag is marked as a release and is
published to run so that the assets it needs (mainly compiled devbox
binary) it publicly available before building and pushing a container
image to dockerhub.

## How was it tested?
need to wait for the next release to truly test.
  • Loading branch information
mohsenari committed Sep 30, 2024
1 parent 8ca1f75 commit f66f7a9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/docker-image-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: docker-image-release

on:
push:
tags:
- '[0-9]+.[0-9]+.[0-9]+'
release:
types:
- published
workflow_dispatch:
inputs:
tag:
Expand Down

0 comments on commit f66f7a9

Please sign in to comment.