New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set overflow and maxlines limit to null if text is expanded, otherwis… #43

Open

veronikalaskova wants to merge 1 commit into jesusrp98:master from veronikalaskova:expand-text-max-lines

veronikalaskova commented Jun 12, 2024

This PR fixes getting maxLines value depending on whether text is expanded or not.

The current _maxLines method returns the value of 66 if the text widget is expanded and has an ellipsis overflow. This has 2 issues.

The overflow is irrelevant when the text is expanded
2 ^ 64 returns 66

The fix sets maxLines to be null if the text is expanded, otherwise use maxLines which is passed in.


          set overflow and maxlines limit to null if text is expanded, otherwis…

2e3bdeb

…e use widget overflow/maxlines values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet