-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix the non modular error within Xcode7.1 #1284
Conversation
I don't know why Travis doesn't find the file, maybe because it's not linked with JSQSystemSound, but it works |
hey @baoluo - sounds like you have something wrong with your xcode project setup. this change shouldn't make a difference. |
Hello @jessesquires, Thank you for your response, it does't change anything for you, but for those who use Xcode7.1 and Swift it will. I made this project https://github.com/processone/xmpp-messenger-ios, and some user reported the issue when they upgraded to Xcode 7.1 |
I am using Xcode 7.1 with Swift and we into heavy internal testing but no one has yet reported any issue on these lines... (yet) |
I can assure you that there is people out there including me who have this problem. As I said, it doesn't change anything for the rest of you, it just solve the issue for us. |
I'm using Xcode 7.1. Built and ran the demo project without any issues. |
This is the opened issue, it will only show the error from the xmppFramework, but when I fixed these errors, one in JSQMessageViewController popped up. processone/xmpp-messenger-ios#15 |
@jessesquires, @svtechnology Many other projects have the same issue, just for an example, please check these issues in Mantle and ParsePlatform projects: Mantle/Mantle#626 Non-modular import statements in Objective-C pods in some cases can cause problems for dependent Swift pods. Please accept this PR. |
@abbasmousavi - interesting. I'll look into this more. |
i had to do this as well to get my app to build |
@marco1981 Of course you have to put the use_frameworks! into the Podfile, it's mandatory if you use Pod with Swift files. |
More info: CocoaPods/CocoaPods#4056 (comment)
|
This will have to wait until after the I've marked it for the iOS 7 does not support frameworks, which is why we can't make this change right now. |
fixed by #1649 |
No description provided.