Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Fix the non modular error within Xcode7.1 #1284

Closed
wants to merge 1 commit into from

Conversation

baoluo
Copy link

@baoluo baoluo commented Oct 26, 2015

No description provided.

@baoluo
Copy link
Author

baoluo commented Oct 26, 2015

I don't know why Travis doesn't find the file, maybe because it's not linked with JSQSystemSound, but it works

@jessesquires
Copy link
Owner

hey @baoluo - sounds like you have something wrong with your xcode project setup. this change shouldn't make a difference.

@baoluo
Copy link
Author

baoluo commented Oct 28, 2015

Hello @jessesquires,

Thank you for your response, it does't change anything for you, but for those who use Xcode7.1 and Swift it will.

I made this project https://github.com/processone/xmpp-messenger-ios, and some user reported the issue when they upgraded to Xcode 7.1

@dart-h-vader
Copy link

I am using Xcode 7.1 with Swift and we into heavy internal testing but no one has yet reported any issue on these lines... (yet)

@baoluo
Copy link
Author

baoluo commented Oct 28, 2015

I can assure you that there is people out there including me who have this problem.

As I said, it doesn't change anything for the rest of you, it just solve the issue for us.

@jessesquires
Copy link
Owner

I'm using Xcode 7.1. Built and ran the demo project without any issues.

@baoluo
Copy link
Author

baoluo commented Oct 29, 2015

This is the opened issue, it will only show the error from the xmppFramework, but when I fixed these errors, one in JSQMessageViewController popped up. processone/xmpp-messenger-ios#15

@abbasmousavi
Copy link

@jessesquires, @svtechnology Many other projects have the same issue, just for an example, please check these issues in Mantle and ParsePlatform projects:

Mantle/Mantle#626
https://github.com/ParsePlatform/ParseFacebookUtils-iOS/issues/2
https://github.com/search?l=Objective-C&q=non-modular+import&ref=searchresults&type=Issues&utf8=✓

Non-modular import statements in Objective-C pods in some cases can cause problems for dependent Swift pods.

Please accept this PR.

@jessesquires
Copy link
Owner

@abbasmousavi - interesting. I'll look into this more.

@jessesquires jessesquires reopened this Nov 5, 2015
@nathanielescribano
Copy link

i had to do this as well to get my app to build

@MarcoFilosi
Copy link

This pull request doesn't compile since you need also add use_frameworks! into Podfile and run pod install using cocoapods 0.39.0. I've created a similar pull request #1325
See also issue: #1322

@baoluo
Copy link
Author

baoluo commented Nov 25, 2015

@marco1981 Of course you have to put the use_frameworks! into the Podfile, it's mandatory if you use Pod with Swift files.

@jessesquires
Copy link
Owner

More info:

CocoaPods/CocoaPods#4420

CocoaPods/CocoaPods#4056 (comment)

• If you get an error stating "Include of non-modular header inside framework module" for a
framework that previously compiled, make sure the "Always Search User Paths"
build setting is set to "No". The default is "Yes" only for legacy reasons. (22784786)

@jessesquires jessesquires modified the milestones: 8.0.0, 7.2.1 Feb 7, 2016
@jessesquires
Copy link
Owner

This will have to wait until after the 7.2.1 release.

I've marked it for the 8.0.0 milestone, which is when iOS 7 will be dropped.

iOS 7 does not support frameworks, which is why we can't make this change right now.

@jessesquires
Copy link
Owner

fixed by #1649

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants