Fix issues with opening links and files using WSL #3850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes to issues with the current implementation of the OSConfig for WSL:
File explorer
When using the file explorer from WSL, for instance by pressing "o" in the "Files" menu, the explorer always opens on the default landing page. This is caused by the filepath being expressed in WSL format instead of the expected Windows format. For instance:
There's a utility to do that in WSL,
wslpath
. We use it in the Open to format the filename before passing it to the Powershell commandLink URLs
Opening links containing ampersands inside lazygit (a pull-request creation page in BitBucket Server, for instance) returns the following Powershell error:
We fix it by enclosing the URL in single quotes.
Notes on this PR
This is my first PR on this repo, please tell me if something is needed. I read the contributing guide.
The OS-specific logic doesn't appear to be tested in integration and unit tests, so I didn't add tests.
go generate ./...
)