[occjava] adding some feature #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At first glance it looks good. I'm sorry I do not have time to look at it in deep right now, but for sure I'll do as soon as possible. |
jeromerobert
force-pushed
the
master
branch
from
20477c6
to
5416411
Compare
…nd for algorithms Allow to modify safe coplanarity value for algos such as SwapEdge without modifying ridges coplanarity parameter.
Rectangle selection + restore default mode after selection
…moothNodes3DBg regularization operation
The order of the groups in the query are not guaranteed to be the same as in the fan iterator so we must use a set to compare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for doing this occjava. I use it and did add some extra features needed for my project. Maybe other people would find these useful, so here is a pull request.
One caveat. Except for one thing, everything is new. What is not knew is the handling of c++ exceptions. That code was mostly already there but commented out. I guess that you had a good reason to comment it out so, you may want to skip that commit. I can update the pull request if needed.