Instead of an attribute list like "PREF;WORK;FAX", the OSX contacts a… #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pp expects a list like that: "type=PREF;type=WORK;type=FAX". To be compatible to this format, I added a little bit of code to transform it like that.
|
Why is this on hold? |
|
@mgrundkoetter May i ask why you look at the vcard version 4 specs while making a PR for the master branch? |
|
Related to #205. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pp expects a list like that: "type=PREF;type=WORK;type=FAX". To be compatible to this format, I added a little bit of code to transform it like that.
According to the specs from http://tools.ietf.org/html/rfc6350#section-6.4.1, this is also closer to the default implementation. An example there looks like "EMAIL;TYPE=work:[email protected]". Can you confirm the vcard still works on other clients like MS Outlook on Windows or some other tools?
I also adjusted the tests.