allow extention of setProperty(), add socialmedia option #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to-be-the-best
suggested changes
Dec 18, 2018
| * @param string $addr The address of the social media platform. | ||
| * @return $this | ||
| */ | ||
| public function addSocial($type = '', $url) |
There was a problem hiding this comment.
Please add tests for this function
| @@ -245,6 +245,13 @@ protected function parse() | |||
| $key = !empty($types) ? implode(';', $types) : 'default'; | |||
| $cardData->url[$key][] = $value; | |||
| break; | |||
| case 'SOCIALMEDIA': | |||
There was a problem hiding this comment.
Please add tests for parsing this data
There was a problem hiding this comment.
On my todo list, do you have any examples?
|
The vCard standard says we need to use the URL for social media references.This will make it incompatible with the standard. |
update package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, great job continuing to enhance the vCard repo allowing so much reach with a simple file.
After using a simple vCard script for 5 years it is time for an upgrade after reviewing additional properties and functions I found $this repo. Here are 2 suggestions:
Adding a Social Media option, this will allow twitter, flickr, linkedin, etc... to be listed in the vCard
Change the property type for setProperty from private to protected which would allow the ability to extend the class with custom functionality while maintaining the ability to use PHP Composer.
There are a few updates I'd list to submit if this request it approved. Several "type field" options which could be improved, more on this later. Thanks!
Here is a working example with modifications:
vCard for Jason Gegere