fix(fp): Improve suppression for Glassfish Server false positives (round 2) #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends suppression to also suppress for projects under the `org.glassfish` group; such as `javax.json`, `jakarta.json` etc. Signed-off-by: Chad Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
org.glassfish/jakarta.jsonDescription of Change
Extends suppression from #7016 to also suppress for projects under the
org.glassfishgroup; such asjavax.json,jakarta.jsonetc. it seems the full Glassfish server has always been published underorg.glassfish.main, although there are probably artifacts in subgroup for.mainwhich are also false positives, so might require someone with more familiarity with Glassfish server to tweak further.Have test cases been added to cover the new functionality?
N/A