Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configure nvd.api.delay default #6112

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: Configure nvd.api.delay default #6112

merged 1 commit into from
Nov 22, 2023

Conversation

aikebah
Copy link
Collaborator

@aikebah aikebah commented Nov 22, 2023

Configure nvd.api.delay to take the coded defaults and raise log in case of actual misconfiguration to WARN level

Fixes Issue #6111

Description of Change

Add a default for nvd.api.key with value 0 to use the coded API-key present/not-present defaults and raise the log-level in case of Long parsing issues to WARN level as there was an invalid user-configured api delay

Have test cases been added to cover the new functionality?

no

… in case of actual misconfiguration to WARN level
@boring-cyborg boring-cyborg bot added the core changes to core label Nov 22, 2023
@aikebah aikebah changed the title fix: Configure nvd.api.delay to take the coded defaults and raise log… fix: Configure nvd.api.delay Nov 22, 2023
@aikebah aikebah changed the title fix: Configure nvd.api.delay fix: Configure nvd.api.delay default Nov 22, 2023
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong
Copy link
Owner

The IT will fail. I'm working on a work around for the release testing.

@jeremylong jeremylong added this to the 9.0.1 milestone Nov 22, 2023
@jeremylong jeremylong merged commit 0b86bca into main Nov 22, 2023
8 of 9 checks passed
@jeremylong jeremylong deleted the issue-6111 branch November 22, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants