fix: OSS Index Analyzer SocketTimeoutException exception handling based on warn only parameter #5845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
When OSS Index is down and not responding on its TCP socket, a
SocketTimeoutException
is thrown by the analyzer regardless of theANALYZER_OSSINDEX_WARN_ONLY_ON_REMOTE_ERRORS
setting.I encountered this issue this morning in
8.3.1
:Description of Change
This PR will use the
ANALYZER_OSSINDEX_WARN_ONLY_ON_REMOTE_ERRORS
to determine whether an error or warning should be returned in the event of OSS Index causing aSocketTimeoutException
to be raised.Have test cases been added to cover the new functionality?
yes
Thanks for all of your awesome work on Dependency check!