upgrade to babel 7 #27
Open
+5,345
−410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbackor
approved these changes
Jun 19, 2020
amireh
pushed a commit
to instructure/i18nliner-js
that referenced
this pull request
May 24, 2022
This also upgrades it to babel 7 so it should be able to handle other Modern features that it used to not. I will try to get jon to merge the pull request for this jenseng#27 And use the official version but for now we can just use it directly From my pull request branch. Test plan: * with the next commit applied (which changes all the <Fragment>s to <>) * Run bin/rake i18n:generate_js * It should work Change-Id: I2752ff4c18c8e71b8b0530e0572596fa7da9ea8e Reviewed-on: https://gerrit.instructure.com/205377 Reviewed-by: Clay Diffrient <[email protected]> Tested-by: Jenkins QA-Review: Ryan Shaw <[email protected]> Product-Review: Ryan Shaw <[email protected]>
amireh
pushed a commit
to instructure/i18nliner-js
that referenced
this pull request
May 25, 2022
This also upgrades it to babel 7 so it should be able to handle other Modern features that it used to not. I will try to get jon to merge the pull request for this jenseng#27 And use the official version but for now we can just use it directly From my pull request branch. Test plan: * with the next commit applied (which changes all the <Fragment>s to <>) * Run bin/rake i18n:generate_js * It should work Change-Id: I2752ff4c18c8e71b8b0530e0572596fa7da9ea8e Reviewed-on: https://gerrit.instructure.com/205377 Reviewed-by: Clay Diffrient <[email protected]> Tested-by: Jenkins QA-Review: Ryan Shaw <[email protected]> Product-Review: Ryan Shaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is so we can use <> instead of <React.Fragment>