This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Add pagination testing #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sorting is achieved by recreating the data.$records array in a sorted fashion; * Upon completion, either the first page is shown or the array elements are added to the table; * data.$records is now always a plain array of <tr> elements.
This suite verifies that pagination can also be enabled after timbles has been initialized. It verifies this post-init behavior both for pagination as well as sorting.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands upon #26 and improves the existing tests for pagination (issue #12). Stuff that is tested:
The button states aren't tested yet, though this isn't super important I think. What still does need testing is the button set for changing the page size (from clicking on the page rather than calling the
enablePaginationmethod).Regardless, progress :-)