-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-41272] Sketch of an APIStep #71
base: master
Are you sure you want to change the base?
Conversation
CC @mikecirioli: This might be interesting to you, particularly since it looks like it would give you what you were working on in jenkinsci/workflow-support-plugin#73 while avoiding the issue with exposing those classes directly. |
Right, and of course this solves lots of related issues more generally. For example, you could look up |
Test failure probably due to one of the updates I did here to make sure all the GDK methods were whitelisted. Could fix that up if there is interest in this PR. One thing that would be very nice is a way to simultaneously specify the |
Nice @jglick - this is a cleaner implementation than my initial exploration using the data API. @cyrille-leclerc and I were discussing this topic today so I'll take a look how this can be applied to the use cases he is interested in. |
|
This seems fantastic to me - I'd probably add a syntactic sugar step called something like |
You mean, Declarative? :-) |
Well, there is no single Setting those things aside and just focusing on the current |
@jglick Yeah, I brainfarted - we will want specific Though deprecating/removing |
Right, mentioned in the PR description. |
This would be incredibly useful for lots of things. Would this currently be too far away from completion for anyone to reasonably pick up? |
JENKINS-41272
Sketch of how we can provide a general step which offers the exact same information available from the “REST API” (i.e., Stapler exporting) at least for builds. Together with a simple step to set the current build’s
result
/description
/displayName
/keepLog
(which would be better for Declarative anyway!), and a way for thebuild
step to return a simple integer build number, this would allow us to deprecate thecurrentBuild
global variable andRunWrapper
generally.