This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Fix lock release when unexpected errors happen during the build #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plugins » rbenv-plugin #17 SUCCESS |
added 2 commits
September 8, 2014 10:52
|
plugins » rbenv-plugin #18 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
plugins » rbenv-plugin #19 SUCCESS |
|
plugins » rbenv-plugin #20 SUCCESS |
|
plugins » rbenv-plugin #21 SUCCESS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use the rbenv plugin there are many times where if a build fails in an unexpected way the .rbenv_lock file is left behind and other builds fail on the slave node because the .rbenv_lock is still present on the machine.
This PR uses the teardown function to ensure that if a build set the .rbenv_lock that it cleans it up despite any errors that happened during the build.
I also added --no-rdoc and --no-ri to the gem installation command to speed up installation of required gems.