Replace Prototype.js with native JavaScript #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @jenkinsci/core-security-review |
Wadeck
reviewed
Jun 29, 2023
|
testing locally |
|
all looks good thank you |
|
Thank you @gmcdonald. Could this please be released? |
|
Yep will do over the next couple of days |
gmcdonald
added
the
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this blog post for details. Prototype will eventually be removed from Jenkins core. To prepare for this transition, this plugin must be migrated away from Prototype. Accordingly, this PR removes any usages of Prototype in favor of native JavaScript.
To test this PR, I enabled the user experimental flag to remove Prototype and put breakpoints on each changed line. I then added two SSH servers in the Configure page, one with exec enabled and one without. I stepped through all the changed lines of JavaScript in a Freestyle project configuration page, including switching servers from one with exec enabled to one without, and I verified all the changed lines executed successfully with no console log errors.
Fixes #306