Skip to content

Commit

Permalink
Fixups to #801 and #805 (#815)
Browse files Browse the repository at this point in the history
  • Loading branch information
basil committed Aug 1, 2023
1 parent 92da190 commit e2dad99
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ The following properties are overridable:
* `jenkins.version`: The Jenkins version required by the plugin. **Mandatory.** See [Requirements](#requirements) for more info. Being able to specify the `jenkins.version` simplifies testing the plugin with different core versions, which is important (among other reasons) for Plugin Compatibility Testing (PCT).
* `jenkins-test-harness.version`: The [JTH version](https://github.com/jenkinsci/jenkins-test-harness/releases) used to test plugin. Uses split test-harness (see [JENKINS-32478](https://issues.jenkins-ci.org/browse/JENKINS-32478)).
* `hpi-plugin.version`: The HPI Maven Plugin version used by the plugin. (Generally you should not set this to a version _lower_ than that specified in the plugin parent POM.)
* `stapler-plugin.version`: The Stapler Maven plugin version required by the plugin.
* `stapler-maven-plugin.version`: The Stapler Maven plugin version required by the plugin.
* In order to make their versions the same as the used core version, `node.version` and `npm.version` properties are provided.

## Incrementals
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
<jenkins.version>2.361</jenkins.version>
<jenkins-bom.version>${jenkins.version}</jenkins-bom.version>
<jenkins-test-harness.version>2044.v03c87927ff5c</jenkins-test-harness.version>
<license-maven-plugin.version>104.v2171757ee6dd</license-maven-plugin.version>
<lifecycle-mapping.version>1.0.0</lifecycle-mapping.version>
<localizer-maven-plugin.version>1.31</localizer-maven-plugin.version>
<maven-antrun-plugin.version>3.1.0</maven-antrun-plugin.version>
Expand All @@ -95,7 +96,6 @@
<maven-install-plugin.version>3.1.1</maven-install-plugin.version>
<maven-jar-plugin.version>3.3.0</maven-jar-plugin.version>
<maven-javadoc-plugin.version>3.5.0</maven-javadoc-plugin.version>
<license-maven-plugin.version>104.v2171757ee6dd</license-maven-plugin.version>
<maven-project-info-reports-plugin.version>3.4.5</maven-project-info-reports-plugin.version>
<maven-release-plugin.version>3.0.1</maven-release-plugin.version>
<maven-resources-plugin.version>3.3.1</maven-resources-plugin.version>
Expand All @@ -106,7 +106,7 @@
<mockito.version>5.4.0</mockito.version>
<spotbugs-maven-plugin.version>4.7.3.5</spotbugs-maven-plugin.version>
<spotless-maven-plugin.version>2.38.0</spotless-maven-plugin.version>
<stapler-plugin.version>175.vff879c6738b_6</stapler-plugin.version>
<stapler-maven-plugin.version>175.vff879c6738b_6</stapler-maven-plugin.version>

<!-- Filled in by "maven-hpi-plugin" with the path to "org-netbeans-insane-hook.jar" extracted from "jenkins-test-harness" -->
<jenkins.insaneHook />
Expand Down Expand Up @@ -481,7 +481,7 @@
<plugin>
<groupId>io.jenkins.tools.maven</groupId>
<artifactId>stapler-maven-plugin</artifactId>
<version>${stapler-plugin.version}</version>
<version>${stapler-maven-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>
Expand Down

0 comments on commit e2dad99

Please sign in to comment.