Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73813] Show a notification when scheduling a build fails #9787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mawinter69
Copy link
Contributor

When a build is triggered via the UI (either on the job page or via the buildbuttoncolumn in a view) and the crumb is no longer valid, the tooltip was shown that the build was scheduled, although nothing happened.
This change will show a notification when scheduling failed.

image

See JENKINS-73813.

Testing done

Manual testing

  • setup jenkins with users
  • create a job without parameters
  • go to dashboard
  • in a second window logout the user
  • click on schedule build -> notification is shown

Proposed changelog entries

  • Show a notification when scheduling a build fails

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

When a build is triggered via the UI (either on the job page or via the
buildbuttoncolumn in a view) and the crumb is no longer valid, there was
still the tooltip shown that the build was scheduled, whereas nothing
happened.
This change will show a notification when scheduling failed.
@mawinter69
Copy link
Contributor Author

I've chosen to use a notificationBar in case of an error as the hoverNotification doesn't allow to change color.
One idea might be to use a notification also for the success case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant