Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology Cleanup: Introduce createAgent() and createOnlineAgent() in JenkinsRule #337

Closed

Conversation

oleg-nenashev
Copy link
Member

Cleans up API for JenkinsRule. I did not touch HudsonTestCase, because we might want to drop JUnit 3 support alltogether

@oleg-nenashev
Copy link
Member Author

Thanks for the review @offa !

@offa
Copy link
Contributor

offa commented Oct 25, 2021

@oleg-nenashev I've created a PR for your branch which fixes the conflicts.

@jglick jglick linked an issue Nov 3, 2021 that may be closed by this pull request
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-0 I guess. Just adds complexity to the API surface. Would prefer to limit renames to user-facing strings.

@@ -903,39 +903,89 @@ public File createTmpDir() throws IOException {
return env.temporaryDirectoryAllocator.allocate();
}

// TODO replace return types once the Jenkins core is updated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really foresee such a class rename in core? Seems like a lot of disruption for a cosmetic issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not expect it anytime soon TBH. Depends on contributions though

@jglick
Copy link
Member

jglick commented May 2, 2022

More inclined to just use the new terminology incrementally as changes are made, as in #428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Cleanup terminology in the Jenkins Test Harness lib
3 participants