Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update relablings for servicemonitor resource #638

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dmitriy-lukyanchikov
Copy link

What this PR does / why we need it

fix relabelings for servicemonitor, added toyaml because its a list of maps not the single value

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • CHANGELOG.md was updated

@dmitriy-lukyanchikov dmitriy-lukyanchikov requested a review from a team as a code owner May 27, 2022 09:10
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2022
@igorzamyslov
Copy link

What would be required for this PR to be merged?
In our company, we would appreciate the change to add relabelings to the ServiceMonitor

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2022
@timja
Copy link
Member

timja commented Oct 31, 2022

A unit test and conflicts resolving, apologies for missing this PR

@dhhuynh2
Copy link

dhhuynh2 commented Dec 9, 2022

Hi @dmitriy-lukyanchikov , was curious on the status on this PR. Would love to see this merged, let me know if I could help out.

@piotrwielgolaski-tomtom
Copy link
Contributor

this looks like to be fixed on main branch, so can you close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants