Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run in Java 6, Update to 1.532.1 parent, added extra metrics #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Run in Java 6, Update to 1.532.1 parent, added extra metrics #1

wants to merge 10 commits into from

Conversation

JoshiiSinfield
Copy link

Few changes made as described in title.

Main items are:

  • Updated to run under Java 6
  • upped the parent pom to be 1.532.1, therefore depends on Jenkins LTS 1.532.1?
  • Update some of the logging to the Job console. Couple of typos and added extra wording to make more informative.
  • Add the ability to have a "base name". So within the Manage Jenkins -> Configure there's an option to set a "base queue name" which is prepended to every queue in a job. This stemmed from some of our teams having separate Jenkins instances, but sharing Graphite so wanting to easily separate metrics for each job per team.
  • Also added boolean metrics of BUILD_FAILED (sends a 0 value) and BUILD_SUCCESSFUL(sends a 1). We don't keep much job history in order to try and keep Jenkins streamlined.

Hope this is all OK... first Pull Request!

Cheers,
Johsh

@cloudbees-pull-request-builder
Copy link

plugins » graphite-plugin #1 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

joachim-rodrigues pushed a commit that referenced this pull request Apr 20, 2014
@mnaboka
Merge pull request #1 from darkonie/graphiteIntegrator
34d67b9 
Add UDP transport for carbon graphite; Fix concurrent build bug; Add sup...
@joachim-rodrigues
Copy link
Member

Pull request seems ok, but need to merge conflicts (see previous pull request ) then i'll integrate your changes.
Thanks

JoshiiSinfield and others added 9 commits April 23, 2014 15:40
@JoshiiSinfield
Allow the plugin to build under Java 6
049a023 
correct some missed off generics and changed the target/source within
the pom. this allowed maven to succesfully install or package using
java6u45
@JoshiiSinfield
update project file and classpath
4c2ac75
up the plugin parent version to get it working with 1.532.1
c7d9752 
the plugin wasn't showing up in Manage Jenkins or in the Post Build
Action menu on 1.532.1 when the parent set to 1.509.1.

Updated the version and it now shows up and works.

Change-Id: Idbd9902a9ab7aa712402225db07c07699f42d791
updated logging, how the queue name is made up, added epoch time into
f627fd9 
the data to send


also updated the readme with the text which was in the description of
the repository.

Change-Id: Ie5cb6921ebc17bb5b98dacad7423590f3b8e92d4
removed debug logging accidentally left in a previous commit
98746d2 
Change-Id: I877bd900e54296f0c7c5fd85481e0cdf09765c25
Add support for running in Freestyle Jobs
a5432ed 
In order t record metrics from ant builds we need to be able to send
metrics from a freestyle project. This adds that support, however the
freestyle projects don't get test result actions unless junit xml files
are archived/recorded ( I think) therefore added in a null check before
sending any test statistics to avoid nullpointerexceptions 

Change-Id: Ieb8fc419b6b7068a74a5f1210d841e62f625310d
@JoshiiSinfield
WIP - add configuration value for base name of queue
72aa3d2 
added in the workings for a default/base queue name within the main
plugin configuration. This shall enable all jobs to have the same prefix
for the Graphite queue, set in a common location.


Still WIP as need to verify does what it says on the tin!
Add validation for base queue name
f763329 
added validation for user input into global setting text box

added validation within AbstractMetric for empty/null value


Change-Id: I8fa2b751612889fa9e5481d24635b908ba0162c8
Add Build_failed and Build_Successful metrics
799d44f 
also added correct classpath and project file

Change-Id: I499bffe890d28668e9da79b21d4260a7f7a80244
@cloudbees-pull-request-builder
Copy link

plugins » graphite-plugin #5 SUCCESS
This pull request looks good

@JoshiiSinfield
Copy link
Author

Hi @joachim-rodrigues. I merged this in (sort of) with the previous pull request a while ago...

Is it OK?

Cheers,
Josh

@joachim-rodrigues
Copy link
Member

Hi
Sorry for the delay
i'll do the merge this week

Thanks

Joachim

On Thu, Jul 17, 2014 at 10:56 PM, Josh Sinfield [email protected]
wrote:

Hi @joachim-rodrigues https://github.com/joachim-rodrigues. I merged
this in (sort of) with the previous pull request a while ago...

Is it OK?

Cheers,
Josh

—
Reply to this email directly or view it on GitHub
#1 (comment)
.

@JoshiiSinfield
Copy link
Author

Not a problem,

I was just checking I hadn’t made a mistake ☺

Thanks,

Josh

From: joachim-rodrigues [mailto:[email protected]]
Sent: 21 July 2014 17:01
To: jenkinsci/graphite-plugin
Cc: Joshua Sinfield
Subject: Re: [graphite-plugin] Run in Java 6, Update to 1.532.1 parent, added extra metrics (#1)

Hi
Sorry for the delay
i'll do the merge this week

Thanks

Joachim

On Thu, Jul 17, 2014 at 10:56 PM, Josh Sinfield <[email protected]mailto:[email protected]>
wrote:

Hi @joachim-rodrigues https://github.com/joachim-rodrigues. I merged
this in (sort of) with the previous pull request a while ago...

Is it OK?

Cheers,
Josh

—
Reply to this email directly or view it on GitHub
#1 (comment)
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-49625467.
http://www.cdl.co.uk/

http://twitter.com/CDL_Software http://www.facebook.com/CDL-Software http://www.linkedin.com/company/cdl-cheshire-datasystems-ltd-

Please consider the environment - Do you really need to print this email?

This email is intended only for the person(s) named above and may contain private and confidential information. If it has come to you in error, please destroy and permanently delete any copy in your possession, and contact us on +44 (0)161 480 4420. The information in this email is copyright © CDL Group Holdings Limited. We cannot accept liability for any loss or damage sustained as a result of software viruses. It is your responsibility to carry out such virus checking as is necessary before opening any attachment.

Cheshire Datasystems Limited uses software which automatically screens incoming emails for inappropriate content and attachments. If the software identifies such content or attachment, the email will be forwarded to our Technology department for checking. You should be aware that any email that you send to Cheshire Datasystems Limited is subject to this procedure.

Cheshire Datasystems Limited, Strata House, Kings Reach Road, Stockport, SK4 2HD
Registered in England and Wales with company number 3991057
VAT registration: 727 1188 33

@andyfcdl
Updated to cover later version of Jenkins.
3079872 
1. The .jelly files were updated to cover off the latest XSS support
sauch that they can be used within the Jenkins UI.

2. The deprecated getTestResultAction() method is no longer available in
Jenkins and this causes no metrics to be logged due to missing method
errors. Replaced these with the recommended getAction() calls.

3. Updated the POM to reference a later version of the HPI plug in and
be based on a later version of Jenkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshiiSinfield @cloudbees-pull-request-builder @jenkinsadmin @joachim-rodrigues @andyfcdl