Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.479 #346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

darinpope
Copy link

Used OpenRewrite to convert to Java 17 syntax

Testing done

ran mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

* update to Java 17
* use matching plugin BOM
Used OpenRewrite
@darinpope darinpope requested a review from a team as a code owner October 16, 2024 20:54
@github-actions github-actions bot added the dependencies Dependency related change label Oct 16, 2024
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Oct 16, 2024

Thanks! A similar pull request includes additional changes for the Java EE 8 to Jakarta EE 9 transition. That pull request is:

We'll want to highlight the Java EE 8 to Jakarta EE 9 transition in one of our sessions, since that transition is a key component of the 2.479 release.

There is an OpenRewrite recipe that is worth trying in our environment. It won't transform StaplerRequest to StaplerRequest2 or StaplerResponse to StaplerResponse2 but it will handle the javax.servlet to jakarta.servlet namespace change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants