Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern HTML tags, stop using color in text #267

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Use modern HTML tags, stop using color in text #267

merged 2 commits into from
Dec 16, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Dec 16, 2023 •
edited
Loading

Use modern HTML tags, stop using color in text

  • Minor grammar fix
  • Replace b tags with strong, stop using color in text

Testing done

Checked that rendering of the HTML pages looks as expected in both light and dark themes.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

@MarkEWaite
Minor grammar fix
2934c6f
@MarkEWaite
Replace <b> tags with <strong>, stop using color in text
ae2f822 
The blue text is very hard to read on a dark theme.  The red text is
not friendly to users that are color blind.  Remove them both so that
the text is easier to read.
@MarkEWaite MarkEWaite added the documentation Improvements or additions to documentation label Dec 16, 2023
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 16, 2023 14:00
@MarkEWaite MarkEWaite merged commit aa169ff into jenkinsci:master Dec 16, 2023
17 checks passed
@MarkEWaite MarkEWaite deleted the replace-b-with-strong-in-html branch December 16, 2023 14:40
@MarkEWaite MarkEWaite changed the title Replace <b> tags with <strong>, stop using color in text Use modern HTML tags, stop using color in text Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite