Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use primitive types #253

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Conversation

StefanSpieker
Copy link
Contributor

Instead of using Bolean and Integer, just use primitive types

Testing done

Tested locally with hpi:run and ran Unit Tests

Submitter checklist

@StefanSpieker StefanSpieker requested a review from a team as a code owner October 15, 2023 09:28
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Oct 15, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I reviewed the usage of those variables and all cases looks safe to me for this transition.

@MarkEWaite MarkEWaite merged commit 8f475be into jenkinsci:master Oct 15, 2023
16 checks passed
@StefanSpieker StefanSpieker deleted the primitive_type branch October 15, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants