use primitive types

jenkinsci · Oct 15, 2023 · a36db0d · a36db0d
1 parent aaaa329
commit a36db0d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/badge/extensions/BuildIdRunSelectorExtension.java b/src/main/java/org/jenkinsci/plugins/badge/extensions/BuildIdRunSelectorExtension.java
@@ -14,8 +14,8 @@
 public class BuildIdRunSelectorExtension implements InternalRunSelectorExtensionPoint {
     @Override
     public Run select(Job project, String build, Run run) {
-        Integer buildNr = 1;
-        Boolean buildIdIsInteger = true;
+        int buildNr = 1;
+        boolean buildIdIsInteger = true;
         try {
             buildNr = Integer.parseInt(build);
         } catch (NumberFormatException e) {

diff --git a/src/main/java/org/jenkinsci/plugins/badge/extensions/BuildParameterRunSelectorExtension.java b/src/main/java/org/jenkinsci/plugins/badge/extensions/BuildParameterRunSelectorExtension.java
@@ -89,16 +89,16 @@ private Run findSpecific(Job job, Run run, String what, String specific) {
                 }
 
                 if (run != null) {
-                    Boolean doBreak = specific == null;
+                    boolean doBreak = specific == null;
                     if (!doBreak) {
                         Result result = run.getResult();
                         if (result != null) {
-                            Boolean isCompleted = result.isCompleteBuild();
-                            Boolean isSuccessful = result == Result.SUCCESS;
-                            Boolean isFailed = result == Result.FAILURE;
-                            Boolean isUnstable = result == Result.UNSTABLE;
-                            Boolean isUnsuccessful = !isSuccessful;
-                            Boolean isStable = isSuccessful;
+                            boolean isCompleted = result.isCompleteBuild();
+                            boolean isSuccessful = result == Result.SUCCESS;
+                            boolean isFailed = result == Result.FAILURE;
+                            boolean isUnstable = result == Result.UNSTABLE;
+                            boolean isUnsuccessful = !isSuccessful;
+                            boolean isStable = isSuccessful;
 
                             doBreak = (specific.equals("Completed") && isCompleted)
                                     || (specific.equals("Successful") && isCompleted && isSuccessful)