Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): Enhance Docker build configuration #45

Closed
wants to merge 19 commits into from

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Oct 23, 2024

Discussion Draft - Not Ready for Merge

This draft outlines proposed changes to improve our Docker infrastructure. I plan to submit a separate PR specifically addressing the JDK8 issue.

Proposed Changes:

  • Implement buildx for multi-platform builds
  • Add Dependabot for automated dependency updates
  • Standardize Dockerfile syntax
  • Align JDK versions with requirements

This initiative follows up on jenkins-infra/helpdesk#4364. The primary goal is to correctly match image dependencies with their corresponding JDK versions (e.g., JDK 8 for jdk8 images, JDK 11 for jdk11 images).

Note: This is a work in progress and open for discussion.

Testing Performed

make && docker run -ti --rm jenkins/jnlp-agent-jdk8:latest

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

gounthar and others added 19 commits October 23, 2024 09:36
chore(docker): Move to buildx and adds dependabot
fix(dependabot): Targets each and every Dockerfile.
Bumps python from 2-alpine to 3-alpine.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps dotnet/core/sdk from 3.1-alpine to 3.1.401-alpine.

---
updated-dependencies:
- dependency-name: dotnet/core/sdk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps golang from 1.15-alpine3.12 to 1.16-alpine3.12.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps powershell from 7.1.0-alpine-3.10 to 7.4-alpine-3.17.

---
updated-dependencies:
- dependency-name: powershell
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps ruby from 3.2.1-bullseye to 3.3.5-bullseye.

---
updated-dependencies:
- dependency-name: ruby
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…python-3-alpine

deps: bump python from 2-alpine to 3-alpine in /python/python2
…et/core/sdk-3.1.401-alpine

deps: bump dotnet/core/sdk from 3.1-alpine to 3.1.401-alpine in /coresdk/31
….16-alpine3.12

deps: bump golang from 1.15-alpine3.12 to 1.16-alpine3.12 in /golang
…ershell-7.4-alpine-3.17

deps: bump powershell from 7.1.0-alpine-3.10 to 7.4-alpine-3.17 in /powershell
…5-bullseye

deps: bump ruby from 3.2.1-bullseye to 3.3.5-bullseye in /ruby
@gounthar
Copy link
Contributor Author

This PR addressed multiple concerns simultaneously without corresponding GitHub issues to track them. To maintain better focus and traceability, I am closing this PR and eventually creating separate issues for each distinct improvement needed.

@gounthar gounthar closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant