Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test jenkinsci/maven-plugin#345 #3718

Closed

Conversation

yaroslavafenkin
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin requested a review from a team as a code owner October 9, 2024 15:58
@darinpope darinpope marked this pull request as draft October 9, 2024 16:29
@darinpope
Copy link
Contributor

@yaroslavafenkin don't forget to add the weekly-test label

@yaroslavafenkin
Copy link
Contributor Author

@yaroslavafenkin don't forget to add the weekly-test label

I lack permissions to do that directly via UI. Is there a bot for that?

@MarkEWaite
Copy link
Contributor

@yaroslavafenkin don't forget to add the weekly-test label

I lack permissions to do that directly via UI. Is there a bot for that?

Good point. There's a solution for that:

To minimize cloud resources, PCT is not run at all by default on pull requests, only some basic sanity checks. Add the label full-test to run PCT in a PR. If you lack triage permission and so cannot add this label, then you may instead

echo 'TODO delete me' > full-test
git add full-test
git commit -m 'Run full tests'
while keeping the PR in draft until tests pass and this file can be deleted.

Similarly, the weekly-test label (or marker file) can be used to run tests on weekly releases in isolation.

@yaroslavafenkin
Copy link
Contributor Author

@yaroslavafenkin don't forget to add the weekly-test label

I lack permissions to do that directly via UI. Is there a bot for that?

Good point. There's a solution for that:

To minimize cloud resources, PCT is not run at all by default on pull requests, only some basic sanity checks. Add the label full-test to run PCT in a PR. If you lack triage permission and so cannot add this label, then you may instead
echo 'TODO delete me' > full-test
git add full-test
git commit -m 'Run full tests'
while keeping the PR in draft until tests pass and this file can be deleted.
Similarly, the weekly-test label (or marker file) can be used to run tests on weekly releases in isolation.

Great to know, thanks for sharing. I'll use that in the future.

@basil
Copy link
Member

basil commented Oct 10, 2024

@basil basil closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants